Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: eslint-plugin-react supports ESLint v9 #91

Merged
merged 1 commit into from
Jul 22, 2024

Conversation

mdjermanovic
Copy link
Member

Prerequisites checklist

What is the purpose of this pull request?

eslint-plugin-react now supports ESLint v9. This PR updates @eslint/migrate-config to not use the compat utility with eslint-plugin-react in generated configs.

What changes did you make? (Give an overview)

Removed eslint-plugin-react from the list of plugins that need the compat utility.

Also replaced eslint-plugin-react with eslint-plugin-import in tests that checks how migration works with two plugins that need the compat utility.

Related Issues

Is there anything you'd like reviewers to focus on?

Copy link
Member

@nzakas nzakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Should we wait for the Node.js v22 fix before merging?

@nzakas
Copy link
Member

nzakas commented Jul 22, 2024

All fixed, so merging.

@nzakas nzakas merged commit 7664bf8 into main Jul 22, 2024
14 checks passed
@nzakas nzakas deleted the eslintpluginreact-eslintv9 branch July 22, 2024 15:25
@github-actions github-actions bot mentioned this pull request Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants