This repository has been archived by the owner on Oct 28, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Replaced cpp-ethereum for aleth #5772
Open
const-ntino
wants to merge
1
commit into
ethereum:master
Choose a base branch
from
const-ntino:patch-1
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaced cpp-ethereum for aleth
Codecov Report
@@ Coverage Diff @@
## master #5772 +/- ##
==========================================
+ Coverage 64% 64.06% +0.05%
==========================================
Files 359 359
Lines 30774 30774
Branches 3416 3416
==========================================
+ Hits 19697 19715 +18
+ Misses 9855 9838 -17
+ Partials 1222 1221 -1 |
chfast
suggested changes
Oct 21, 2019
@@ -22,13 +22,13 @@ RUN apk add --no-cache \ | |||
linux-headers \ | |||
leveldb-dev --repository http://dl-cdn.alpinelinux.org/alpine/edge/testing/ \ | |||
&& sed -i -E -e 's|#warning|//#warning|' /usr/include/sys/poll.h \ | |||
&& git clone --recursive https://github.com/ethereum/cpp-ethereum --branch develop --single-branch --depth 1 \ | |||
&& git clone --recursive https://github.com/ethereum/aleth --branch develop --single-branch --depth 1 \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The branch should be master
now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pedrocns kindly do the needful.
@pedrocns do you want to finish this? |
chamajcpradel
suggested changes
Jan 31, 2020
@@ -22,13 +22,13 @@ RUN apk add --no-cache \ | |||
linux-headers \ | |||
leveldb-dev --repository http://dl-cdn.alpinelinux.org/alpine/edge/testing/ \ | |||
&& sed -i -E -e 's|#warning|//#warning|' /usr/include/sys/poll.h \ | |||
&& git clone --recursive https://github.com/ethereum/cpp-ethereum --branch develop --single-branch --depth 1 \ | |||
&& git clone --recursive https://github.com/ethereum/aleth --branch develop --single-branch --depth 1 \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pedrocns kindly do the needful.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced cpp-ethereum for aleth