Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking events improvements #11521

Open
konopkja opened this issue Oct 27, 2023 · 7 comments · Fixed by #11708
Open

Tracking events improvements #11521

konopkja opened this issue Oct 27, 2023 · 7 comments · Fixed by #11708
Assignees
Labels
dev required This requires developer resources feature ✨ This is enhancing something existing or creating something new Status: Stale This issue is stale because it has been open 30 days with no activity. tooling 🔧 Changes related to tooling of the project

Comments

@konopkja
Copy link
Contributor

konopkja commented Oct 27, 2023

We are currently lacking some event tracking and other tracking needs to be changed.

A. Changes for https://ethereum.org/en/wallets/find-wallet/

  1. expanding and collapsing wallet detail: remove collapse trigger "More info wallet false" and keep only the expand event trigger
  2. Icon links to wallet: "WalletExternalLinkList" tracks link to website, discord and twitter as one event, those 3 action should be separate
  3. Check out main wallet button isnt tracked: Add tracking for the main button in the detail of wallets

B. Global tracking changes

event tracking is being translated currently

  • this creates confusion in understanding what audience is included in the main english tracking (it seems to be EN version + other not translated pages), the change should be to keep in only the EN version and for other languages the events should be changes to contain the language shortcut. (if this is too difficult, we can discuss other solutions)
@konopkja konopkja added the feature ✨ This is enhancing something existing or creating something new label Oct 27, 2023
@github-actions github-actions bot added the needs triage 📥 This issue needs triaged before being worked on label Oct 27, 2023
@konopkja konopkja added the dev required This requires developer resources label Oct 31, 2023
@wackerow wackerow self-assigned this Nov 1, 2023
@wackerow
Copy link
Member

Noting that #11708 only fixed (A) above... going to reopen to keep track of (B) where a few additional changes will need to be made. These should wait until after the initial Next.js migration is completed.

@wackerow wackerow reopened this Nov 29, 2023
Copy link
Contributor

This issue is stale because it has been open 45 days with no activity.

@github-actions github-actions bot added the Status: Stale This issue is stale because it has been open 30 days with no activity. label Jan 14, 2024
@wackerow wackerow added question ❓ Further information is requested tooling 🔧 Changes related to tooling of the project and removed Status: Stale This issue is stale because it has been open 30 days with no activity. needs triage 📥 This issue needs triaged before being worked on labels Jun 13, 2024
@wackerow
Copy link
Member

wackerow commented Jun 13, 2024

@konopkja How is this looking with the latest setup? Do we need to dedicate a task to solving B above still, or has this resolved and can be closed? If still needed, could you help clarify here with examples of where this is showing up?

If I recall, there are some places where we're trying to log something where the only string we have available to identify/differentiate it is the translated string.

// src/components/Nav/Mobile/LvlAccordion.tsx:L113

                  onClick={() => {
                    trackCustomEvent({
                      eventCategory: "Mobile navigation menu",
                      eventAction: `Level ${lvl - 1} section changed`,
                      eventName: `${
                        isExpanded ? "Close" : "Open"
                      } section: ${label} - ${description.slice(0, 16)}...`,
                    })
                  }}

This is the one coming to mind right now.. when inside the mobile navigation menu, tapping on the accordions will log which one, identified by it's label, which is the same label being displayed to the user. This value is already translated, and the English version is not available from inside this component.

Not saying it isn't doable, but would just require some thought, especially with the performance epic going on right now. Need to be aware of what bloat could be introduced here.

@konopkja
Copy link
Contributor Author

the changes to find wallet are implemented, the global changes pending review

@konopkja
Copy link
Contributor Author

konopkja commented Jul 5, 2024

@wackerow this is still an issue, for example on czech version of https://ethereum.org/cs/wallets/find-wallet/ we send:

1. personas are translated

Event Action Jste v kryptoměnách nový?
Event Category UserPersona
Event Name Jste v kryptoměnách nový? true

japanese is https://ethereum.org/ja/wallets/find-wallet/

Event Action 暗号資産が始めたの方
Event Category UserPersona
Event Name 暗号資産が始めたの方 true

result in matomo: it will be counted separately from english version of the event (GOOD)

  1. filters

in cs:

Event Action Buy crypto / Sell for fiat
Event Category WalletFilterSidebar
Event Name withdraw_crypto true

in japanese:

Event Action 暗号資産の購入 / 法定通貨への換金
Event Category WalletFilterSidebar
Event Name withdraw_crypto true

result: CS clicks will be included in stats for EN, JA clicks will be separate (BAD)

Copy link
Contributor

github-actions bot commented Aug 5, 2024

This issue is stale because it has been open 30 days with no activity.

@github-actions github-actions bot added the Status: Stale This issue is stale because it has been open 30 days with no activity. label Aug 5, 2024
@wackerow wackerow removed Status: Stale This issue is stale because it has been open 30 days with no activity. question ❓ Further information is requested labels Aug 8, 2024
Copy link
Contributor

github-actions bot commented Sep 8, 2024

This issue is stale because it has been open 30 days with no activity.

@github-actions github-actions bot added the Status: Stale This issue is stale because it has been open 30 days with no activity. label Sep 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev required This requires developer resources feature ✨ This is enhancing something existing or creating something new Status: Stale This issue is stale because it has been open 30 days with no activity. tooling 🔧 Changes related to tooling of the project
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants