-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tracking events improvements #11521
Comments
Noting that #11708 only fixed (A) above... going to reopen to keep track of (B) where a few additional changes will need to be made. These should wait until after the initial Next.js migration is completed. |
This issue is stale because it has been open 45 days with no activity. |
@konopkja How is this looking with the latest setup? Do we need to dedicate a task to solving B above still, or has this resolved and can be closed? If still needed, could you help clarify here with examples of where this is showing up? If I recall, there are some places where we're trying to log something where the only string we have available to identify/differentiate it is the translated string. // src/components/Nav/Mobile/LvlAccordion.tsx:L113
onClick={() => {
trackCustomEvent({
eventCategory: "Mobile navigation menu",
eventAction: `Level ${lvl - 1} section changed`,
eventName: `${
isExpanded ? "Close" : "Open"
} section: ${label} - ${description.slice(0, 16)}...`,
})
}} This is the one coming to mind right now.. when inside the mobile navigation menu, tapping on the accordions will log which one, identified by it's Not saying it isn't doable, but would just require some thought, especially with the performance epic going on right now. Need to be aware of what bloat could be introduced here. |
the changes to find wallet are implemented, the global changes pending review |
@wackerow this is still an issue, for example on czech version of https://ethereum.org/cs/wallets/find-wallet/ we send: 1. personas are translated
japanese is https://ethereum.org/ja/wallets/find-wallet/
result in matomo: it will be counted separately from english version of the event (GOOD)
in cs:
in japanese:
result: CS clicks will be included in stats for EN, JA clicks will be separate (BAD) |
This issue is stale because it has been open 30 days with no activity. |
This issue is stale because it has been open 30 days with no activity. |
We are currently lacking some event tracking and other tracking needs to be changed.
A. Changes for https://ethereum.org/en/wallets/find-wallet/
B. Global tracking changes
event tracking is being translated currently
The text was updated successfully, but these errors were encountered: