Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Matomo updates #11708

Merged
merged 2 commits into from
Nov 28, 2023
Merged

Matomo updates #11708

merged 2 commits into from
Nov 28, 2023

Conversation

wackerow
Copy link
Member

@wackerow wackerow commented Nov 21, 2023 •
edited
Loading

Description

Implement updates to Matomo tracking for wallet pages

  • Removes event when collapsing wallet details; only logs when item is expanded
  • Differentiate external links to website vs Twitter vs Discord for wallets
  • "Check out ___" button logging patched -- This required updating the Button component which was not utilizing the MatomoEventOptions being passed.
  • Small refactor to use guard clauses instead of nesting primary logic inside if statements inside matomo.ts

Related Issue

cc: @konopkja Left a note for you about remaining item in that Notion card

@netlify Netlify
Copy link

netlify bot commented Nov 21, 2023 •
edited
Loading

✅ Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit 6a180f4
🔍 Latest deploy log https://app.netlify.com/sites/ethereumorg/deploys/655cf2c9d09fe80008539313
😎 Deploy Preview https://deploy-preview-11708--ethereumorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@corwintines corwintines merged commit ac36c6b into dev Nov 28, 2023
6 checks passed
@corwintines corwintines deleted the matomo-updates branch November 28, 2023 23:29
This was referenced Nov 28, 2023
Merged
Merged
@wackerow wackerow mentioned this pull request Nov 29, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corwintines corwintines corwintines approved these changes

@pettinarip pettinarip Awaiting requested review from pettinarip pettinarip is a code owner

@minimalsm minimalsm Awaiting requested review from minimalsm minimalsm is a code owner

@nhsz nhsz Awaiting requested review from nhsz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tracking events improvements
2 participants
@wackerow @corwintines