Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Contributors component to shadcn #13989

Merged
merged 13 commits into from
Oct 8, 2024

Conversation

Baystef
Copy link
Contributor

@Baystef Baystef commented Sep 27, 2024

I added a new CSS variable --table-background-hover to replace tableBackgroundHover as I didn't see the equivalent in the new variables.

Also, we might need to create a custom LinkBox/LinkOverlay component
I added custom LinkBox/LinkOverlay component

Description

On Localhost
Screenshot 2024-09-27 at 5 42 14 PM
Screenshot 2024-09-27 at 5 42 33 PM

On Production
Screenshot 2024-09-27 at 5 40 38 PM
Screenshot 2024-09-27 at 5 40 52 PM

Related Issue

#13946

Copy link

netlify bot commented Sep 27, 2024

Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit 4534a7d
🔍 Latest deploy log https://app.netlify.com/sites/ethereumorg/deploys/6705810a268ef30008273f46
😎 Deploy Preview https://deploy-preview-13989--ethereumorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
7 paths audited
Performance: 47 (🔴 down 6 from production)
Accessibility: 93 (no change from production)
Best Practices: 89 (🔴 down 9 from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

defihook

This comment was marked as spam.

@pettinarip pettinarip mentioned this pull request Oct 2, 2024
42 tasks
Copy link
Member

@pettinarip pettinarip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Baystef the PR looks great, the LinkBox implementation is really helpful.

I've left one small request on the colors.

src/components/Contributors.tsx Outdated Show resolved Hide resolved
tailwind.config.ts Outdated Show resolved Hide resolved
src/components/ui/link-box.tsx Outdated Show resolved Hide resolved
@Baystef Baystef requested a review from pettinarip October 4, 2024 15:20
Copy link
Member

@pettinarip pettinarip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Baystef! looks great now.

@pettinarip pettinarip merged commit 27d9269 into ethereum:dev Oct 8, 2024
5 of 7 checks passed
@pettinarip pettinarip added the hacktoberfest Track hacktoberfest activity label Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest Track hacktoberfest activity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants