-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate Contributors component to shadcn #13989
Conversation
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Baystef the PR looks great, the LinkBox implementation is really helpful.
I've left one small request on the colors.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Baystef! looks great now.
I added a new CSS variable
--table-background-hover
to replacetableBackgroundHover
as I didn't see the equivalent in the new variables.Also, we might need to create a custom LinkBox/LinkOverlay componentI added custom LinkBox/LinkOverlay component
Description
On Localhost
On Production
Related Issue
#13946