Implement pectra devnet-5 spec #3807
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. |
jochem-brouwer
added
PR state: needs review
PR/Issue state: blocked
and removed
PR state: WIP
labels
|
Have added a review+blocked label, I suggest we use this PR as devnet-5 branch until devnet-4 is taken offline. |
|
Devnet-4 is deleted, so we can now merge Devnet-5 changes into master, have removed blocked label. |
|
Ah ok tests failing, will fix tomorrow (likely block hashes / request hashes since those have changed) |
acolytec3
reviewed
Nov 26, 2024
| // TODO: verify that this is the correct designator | ||
| // The PR https://github.com/ethereum/EIPs/pull/8969 has two definitions of the | ||
| // designator: the original (0xef0100) and the designator added in the changes (0xef01) | ||
| const eip7702Designator = hexToBytes('0xef01') |
There was a problem hiding this comment.
Just confirming my thinking. These only get computed once at run time, right? They aren't recomputed every single time we access this code are they?
There was a problem hiding this comment.
Only computed once! Can also move it somewhere else like types.ts.
|
Have converted this back to "draft" and added blocked label again. This will be our prep-branch for devnet-5. Our master branch will currently support devnet-4 (even though devnet-4 is now nuked). The reason is that the Mekong testnet is devnet-4 specced: https://notes.ethereum.org/@ethpandaops/mekong#Which-versionbranch-do-I-use and it is still up. Point all devnet-5 related PRs to this PR :) (branch |
scorbajio
reviewed
Nov 26, 2024
jochem-brouwer
commented
Nov 27, 2024
|
changed for ethereum/execution-apis#574 are now in the branch |
g11tech
changed the title
* common/evm/vm: implement EIP7623 calldata cost increase * move the floorcost update and add debug log * fix t8ntool empty requests reporting * common: add 7623 * tx: add 7623 validator * t8n: throw on invalid txs * make cspell happy --------- Co-authored-by: harkamal <gajinder@g11.in>
jochem-brouwer
force-pushed
the
devnet-5
branch
from
0d7e696 to
5079664
Compare
|
EVMs BLS tests fail because the test files are outdated. I have updated the addresses, but the tests now fail with "x should not throw" - this throws because we have an assertion check on the gas used and the test files report the old gas (the gas schedule got an update). |
jochem-brouwer
commented
Jan 5, 2025
| if (this.blobVersionedHashes.length > LIMIT_BLOBS_PER_TX) { | ||
| const msg = Legacy.errorMsg(this, `tx can contain at most ${LIMIT_BLOBS_PER_TX} blobs`) | ||
|
|
||
| const limitBlobsPerTx = this.common.param('maxblobGasPerBlock') / this.common.param('blobGasPerBlob') |
There was a problem hiding this comment.
This param is only available if we activate EIP 7691 🤔 Should we introduce a similar value for EIP-4844? 🤔
There was a problem hiding this comment.
I think this was intended, have done so.
|
Ran the latest EEST release, we have some errors on blockchain tests https://github.com/ethereum/execution-spec-tests/releases/tag/pectra-devnet-5%40v1.1.0 Did not yet check state or transaction tests. |
|
We now pass all blockchain, state and transaction tests. To run the transaction tests:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR incorporates the changes of EIP-7702 and EIP-7685 for devnet-5 as outlined in: https://notes.ethereum.org/@ethpandaops/pectra-devnet-5
ethereum/EIPs#8969
ethereum/EIPs#8989
ethereum/execution-apis#574
Will keep this PR as draft, because the 7702 changes might get a follow-up PR (regarding the designator, see: ethereum/EIPs#8969 (comment))Just got convinced that this is not a problem and we should stick to0xef01as "code" when reading from delegated accounts