Imrpove array syntax and visible method name #24
+331
−325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peter279k
commented
Aug 17, 2020
| @@ -17,12 +17,17 @@ | |||
| "php": ">=5.6.0" | |||
| }, | |||
| "require-dev": { | |||
| "phpunit/phpunit": ">=5.5.0", | |||
| "mikey179/vfsStream": "~1" | |||
| "phpunit/phpunit": "^5.5", | |||
There was a problem hiding this comment.
- To avoid latest PHPUnit version installed and unexpected issues, it should let
PHPUnitinstall with5.5.xversions.
To fix following message, it should be mikey179/vfsstream.
Deprecation warning: require-dev.mikey179/vfsStream is invalid, it should not contain uppercase characters. Please use mikey179/vfsstream instead. Make sure you fix this as Composer 2.0 will error.
peter279k
commented
Aug 17, 2020
| before_script: | ||
| - composer self-update | ||
| - composer install --prefer-source --no-interaction --dev |
There was a problem hiding this comment.
Remove --dev to avoid following message:
You are using the deprecated option "dev". Dev packages are installed by default now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed log
php-7.2,php-7.3andphp-7.4tests during Travis CI build.arraysyntax because this package requiresphp-5.6at least.