-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sort keyword arguments #92
Conversation
Pull Request Test Coverage Report for Build 326
💛 - Coveralls |
Hi, this change would be useful for me too. Anything i can do to help get this merged in? |
Hi @sambogoat thanks for this PR (and your other one as well), I will try to look next week. Having schools closed this fall has made a couple part of my job (like open source work) hard to prioritize. We really appreciate your interest and potential contribution! |
@onetonfoot I discussed with my team and we agree this is a useful feature, but did not necessarily want to make it the default behavior. If you could make it controllable and add some unit tests, that would be great. I will promptly review any additional work you (or anyone) does on this PR. Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes requested in comments
Sorry I don't have time to continue working on this. |
Deterministic behavior is always preferable from my point of view and having randomly ordered keyword arguments is problematic for automated integration tests -- I wish this work would get revived at some point! |
Sort the keyword arguments when generating python code #83