Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sort keyword arguments #92

Closed
wants to merge 1 commit into from

Conversation

onetonfoot
Copy link
Contributor

Sort the keyword arguments when generating python code #83

@coveralls
Copy link

Pull Request Test Coverage Report for Build 326

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 79.367%

Totals Coverage Status
Change from base Build 323: 0.02%
Covered Lines: 2251
Relevant Lines: 2721

💛 - Coveralls

@stevematthew
Copy link

Hi, this change would be useful for me too.

Anything i can do to help get this merged in?

@dossett
Copy link
Contributor

dossett commented Nov 10, 2020

Hi @sambogoat thanks for this PR (and your other one as well), I will try to look next week. Having schools closed this fall has made a couple part of my job (like open source work) hard to prioritize. We really appreciate your interest and potential contribution!

@stevematthew
Copy link

Hi @dossett any chance you would have bandwidth to review this PR and #91 too?

Thanks in advance.

@dossett
Copy link
Contributor

dossett commented Dec 28, 2020

@onetonfoot I discussed with my team and we agree this is a useful feature, but did not necessarily want to make it the default behavior. If you could make it controllable and add some unit tests, that would be great. I will promptly review any additional work you (or anyone) does on this PR. Thank you!

Copy link
Contributor

@dossett dossett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes requested in comments

@onetonfoot
Copy link
Contributor Author

Sorry I don't have time to continue working on this.

@onetonfoot onetonfoot closed this Mar 4, 2021
@jdimatteo
Copy link

Deterministic behavior is always preferable from my point of view and having randomly ordered keyword arguments is problematic for automated integration tests -- I wish this work would get revived at some point!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants