Add more DO storage instrumentation #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jahands
requested changes
Apr 2, 2024
jahands
reviewed
Apr 2, 2024
jahands
approved these changes
Apr 2, 2024
jahands
force-pushed
the
do-storage-more-methods
branch
from
58e32d1 to
2e4139f
Compare
jahands
force-pushed
the
do-storage-more-methods
branch
from
2e4139f to
31fdab2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes # [insert GH issue number(s)].
What this PR solves / how to test:
Previously, DO instrumentation copied all options to
attributes. This PR implements special support for most methods (transactionis the only currently existing method onDurableObjectStoragethat isn't handled properly, as it has a rollback method we should ideally proxy/track).I also fixed a bug in
put, pretty sure that the "entries" overload would've caused an exception previously as the instrumentation wasn't prepared for it.