New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make null not proxyable #147

Merged

jahands merged 1 commit into evanderkoogh:main from hansottowirtz:null-not-proxyable

Jun 28, 2024

Contributor

hansottowirtz commented Jun 28, 2024 •

edited

Loading

This crashes:

new Miniflare({
  ...,
  bindings: {
    SOMETHING: null
  }
});

because null crashes in isVersionMetadata.
So I fixed it by checking for null in isProxyable.


          fix: make null not proxyable

Collaborator

jahands commented Jun 28, 2024

Nice! Thanks!

jahands merged commit 153b217 into evanderkoogh:main

1 check passed

hansottowirtz mentioned this pull request

fix: null in isVersionMetadata #148

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet