Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: traceFlags test in isHeadSampled function #151

Merged
merged 1 commit into from
Aug 13, 2024
+3 −3
Merged

fix: traceFlags test in isHeadSampled function #151

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,9 +215,9 @@ Tail Sampling on the other hand is done at the end. Because we record every sing
Example:

```typescript
const tailSampler = (localTrace: LocalTrace): boolean => {
const tailSampler = (traceInfo: LocalTrace): boolean => {
const localRootSpan = traceInfo.localRootSpan as unknown as ReadableSpan
return localRootSpan.spanContext().traceFlags === TraceFlags.SAMPLED
return (localRootSpan.spanContext().traceFlags & TraceFlags.SAMPLED) === TraceFlags.SAMPLED
}
```

Expand Down
2 changes: 1 addition & 1 deletion src/sampling.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ export function multiTailSampler(samplers: TailSampleFn[]): TailSampleFn {

export const isHeadSampled: TailSampleFn = (traceInfo) => {
const localRootSpan = traceInfo.localRootSpan as unknown as ReadableSpan
return localRootSpan.spanContext().traceFlags === TraceFlags.SAMPLED
return (localRootSpan.spanContext().traceFlags & TraceFlags.SAMPLED) === TraceFlags.SAMPLED
}

export const isRootErrorSpan: TailSampleFn = (traceInfo) => {
Expand Down