specify output dir in dist #163
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ackage info embed to avoid package.json path resolution sisue
|
just ran into this :) @evanderkoogh any chance of a merge? |
|
Why is the |
|
Oh whoops, that was for my local installation/deploy for a duct tape
solution, my b
…On Sun, Sep 8, 2024 at 12:57 PM Jacob Hands ***@***.***> wrote:
Why is the dist directory committed in this PR?
—
Reply to this email directly, view it on GitHub
<#163 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAACBRBT7PHYXZCZ35VVJTTZVR6WZAVCNFSM6AAAAABNWVC66KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMZWG42TEOBXGI>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
looks like @evanderkoogh modded to solve, closing this PR |
|
Lol.. I was just about to leave a comment here that I had found another way to fix it.. but thanks for your effort none the less! |
|
is this fixed? It fails I am not sure where to go from here |
|
no it appears to still be borked. |
|
attn @evanderkoogh this still needs to be addressed. See the tsconfig changes in this PR. If you want I can re-PR with your versions changes and remove the whole dist mess from this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updated tsconfig for esm + cjs to explicitly set output dirs; added package info embed to avoid package.json path resolution issue
Fixes #162
What this PR solves / how to test:
testing env:
to test:
npm create cloudflare@latest -- my-first-workercd my-first-workernpm run devnpm i @microlabs/otel-cf-workersnpm run dev, should see error per import / resolution error #162