Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build build-dependent versions.json before build builds #165

Merged
merged 1 commit into from
Sep 10, 2024

Conversation

pkarl
Copy link
Contributor

@pkarl pkarl commented Sep 9, 2024

add cs-version to build script b/c github action builds before it releases (currently version file is only generated in release step

Fixes #164

What this PR solves / how to test:

  • fix failed build

to test:

  • npm run clean
  • npm run build

…eases (currently version file is only generated in release step
@pkarl
Copy link
Contributor Author

pkarl commented Sep 9, 2024

@evanderkoogh 👀

@evanderkoogh evanderkoogh merged commit 9aaa5e4 into evanderkoogh:main Sep 10, 2024
1 check failed
@evanderkoogh
Copy link
Owner

And people wonder why release engineering is a proper job these days :D

Thanks for that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

build & release fails on resolving 'versions.json'
2 participants