fix: extensionless js imports #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems, that there are still some imports left in code, that have no exact extensions. This is not supported by node module resolution process:
Node API - file extensions
Why and where it is usually a problem ?
When running otel-cf-workers code not in the bundled form (together with worker code), particularly in unit tests.
Why it is not noticable and was not mentioned a lot of times before ?
I think, that is exactly due to the previous point: running a Cloudflare worker (even locally) usually includes a bundling step, by esbuild. And, possibly, exactly the bundler solves all the problems with having incorrect import signatures.
But, when writing unit-tests for the workers (if you do not use a bundle at all), that becomes a problem - and module resolutions fails with console errors (in my case, it is the mocha framework):
Important - this is a direct continuation of a previously raised issue:
ESM interoperability question, which as I think, was closed without a real resolution (unfortunately). I also think, we need to re-think and fix all issues mentioned in that issue.