Remove conditional queryCallback

Conditional queryCallback wasn't documented, and it's an antipattern. With Kysely Relations, it's possible to use subqueries.
evoluhq · Oct 26, 2023 · 8eaff48 · 8eaff48 · vercel · Oct 26, 2023
1 parent db84a4e
commit 8eaff48
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/.changeset/hot-moons-invent.md b/.changeset/hot-moons-invent.md
@@ -0,0 +1,7 @@
+---
+"@evolu/common-react": patch
+---
+
+Remove conditional queryCallback
+
+Conditional useQuery callback wasn't documented, and it's an antipattern. With Kysely Relations, it's possible to nest related rows in queries now.
diff --git a/packages/evolu-common-react/src/React.ts b/packages/evolu-common-react/src/React.ts
@@ -12,7 +12,6 @@ import {
   FilterMap,
   FlushSync,
   NanoId,
-  OrNullOrFalse,
   Owner,
   OwnerActions,
   Platform,
@@ -157,7 +156,7 @@ type UseQuery<S extends Schema> = <
   QueryRow extends Row,
   FilterMapRow extends Row,
 >(
-  queryCallback: OrNullOrFalse<QueryCallback<S, QueryRow>>,
+  queryCallback: QueryCallback<S, QueryRow>,
   filterMap: FilterMap<QueryRow, FilterMapRow>,
 ) => {
   /**