Skip to content

Commit

Permalink
Svelte 5.0 support (#1716)
Browse files Browse the repository at this point in the history
* Upgraded deps

* Fixed svelte 5 compiler errors

* fixed import

* run npm build

* Updated svelte

* Update deps

* ensure node is setup before caching.

* set npm cache path

* Add conditional step
  • Loading branch information
niemyjski authored Oct 21, 2024
1 parent 688736d commit 61abb71
Show file tree
Hide file tree
Showing 22 changed files with 441 additions and 233 deletions.
19 changes: 12 additions & 7 deletions .github/workflows/build.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ jobs:
timeout-minutes: 30
defaults:
run:
working-directory: ./src/Exceptionless.Web/ClientApp
working-directory: src/Exceptionless.Web/ClientApp

steps:

Expand All @@ -127,23 +127,28 @@ jobs:
with:
fetch-depth: 0

- name: Cache node_modules
uses: actions/cache@v4
with:
path: node_modules
key: node-modules-${{ hashFiles('package-lock.json') }}

- name: Setup Node.js environment
uses: actions/setup-node@v4
with:
node-version: 20

- name: Cache node_modules
uses: actions/cache@v4
id: cache-node-modules
with:
path: src/Exceptionless.Web/ClientApp/node_modules
key: node-modules-${{ hashFiles('package-lock.json') }}

- name: Install Npm Packages
if: steps.cache-node-modules.outputs.cache-hit != 'true'
run: npm ci --force

- name: Lint Client
run: npm run lint

- name: Build
run: npm run build

- name: Run Unit Tests
run: echo "npm run test:unit"

Expand Down
2 changes: 1 addition & 1 deletion src/Exceptionless.Core/Exceptionless.Core.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
<PackageReference Include="Microsoft.Extensions.Configuration.Binder" Version="9.0.0-rc.2.24473.5" />
<PackageReference Include="Microsoft.Extensions.Diagnostics.HealthChecks" Version="9.0.0-rc.2.24474.3" />
<PackageReference Include="Microsoft.Extensions.Logging" Version="9.0.0-rc.2.24473.5" />
<PackageReference Include="Stripe.net" Version="46.2.0" />
<PackageReference Include="Stripe.net" Version="46.2.1" />
<PackageReference Include="System.DirectoryServices" Version="9.0.0-rc.2.24473.5" />
<PackageReference Include="UAParser" Version="3.1.47" />
<PackageReference Include="Foundatio.Repositories.Elasticsearch" Version="7.17.12" Condition="'$(ReferenceFoundatioRepositoriesSource)' == '' OR '$(ReferenceFoundatioRepositoriesSource)' == 'false'" />
Expand Down
14 changes: 7 additions & 7 deletions src/Exceptionless.Web/ClientApp/eslint.config.js
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
import js from '@eslint/js';
import eslint from '@eslint/js';
import prettier from 'eslint-config-prettier';
import perfectionist from 'eslint-plugin-perfectionist';
import svelte from 'eslint-plugin-svelte';
import globals from 'globals';
import ts from 'typescript-eslint';
import tseslint from 'typescript-eslint';

/** @type {import('eslint').Linter.FlatConfig[]} */
export default [
js.configs.recommended,
...ts.configs.recommended,
export default tseslint.config(
eslint.configs.recommended,
...tseslint.configs.recommended,
...svelte.configs['flat/recommended'],
perfectionist.configs['recommended-natural'],
prettier,
Expand All @@ -25,7 +25,7 @@ export default [
files: ['**/*.svelte'],
languageOptions: {
parserOptions: {
parser: ts.parser
parser: tseslint.parser
}
}
},
Expand All @@ -38,4 +38,4 @@ export default [
'perfectionist/sort-svelte-attributes': 'off'
}
}
];
);
Loading

0 comments on commit 61abb71

Please sign in to comment.