Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create vendor bundle to remove jsdelivr cdn #1423

Merged
merged 1 commit into from
Oct 16, 2023

Conversation

zivillian
Copy link
Contributor

This PR creates a vendor.min.css and vendor.min.js from the already installed node modules using the existing grunt tasks.

Since the installed bootstrap module is 3.4.1 this also updates the bootstrap.min.js from 3.3.7 to 3.4.1

fixes #1056

@CLAassistant
Copy link

CLAassistant commented Oct 13, 2023

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@niemyjski niemyjski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good! thanks for the pr. We might have to wait a tiny bit to merge this until our svelte branch is merged in as it will cause quite the conflict going first.

@niemyjski
Copy link
Member

@zivillian I don't seem to be able to make changes to your branch. We just merged in the svelte changes which makes ClientApp the svelte app and ClientApp.angular the angular app. Would it be possible for you to apply this patch to the ClientApp.angular folder.

@zivillian
Copy link
Contributor Author

@niemyjski I've rebased my commit on the current main

@niemyjski niemyjski merged commit 4b24ab1 into exceptionless:main Oct 16, 2023
3 of 5 checks passed
@niemyjski
Copy link
Member

Thanks for the PR!

@niemyjski
Copy link
Member

@zivillian looks like there is an issue with the font awesome fonts not being loaded

host/fonts/fontawesome-webfont.ttf?v=4.7.0 results in a 404.

Any chance you could take a look at this.

@niemyjski
Copy link
Member

@zivillian I've fixed it :)

@zivillian zivillian deleted the vendor_bundle branch October 16, 2023 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

cdn can't load css and js, can it be changed to local?
3 participants