-
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to PHP 8.3 and PHPUnit 10 #105
Conversation
This allows easy modification for development.
PHPUnit 10 no longer includes data of data sets in its output.
Note to self: Wait a few days after exercism/php#683 was merged before merging this. |
Thanks for taking care of this. I would have preferred a "ping" on the origin PR though. But not important. The one that do the action takes the decisions. :) |
Sorry for obviously being rude. I didn't mean to be. To me, it seemed to be a decision between: "finish this with the solution at hand from debugging for #101 and push this forward", "hope tomasnorre hasn't lost motivation totally due to a lack of help and continue waiting for a solution" or "communicate the solution I found to you and hope you don't feel pushed along". |
Don't worry about it. I haven't lost motivation. But I have times when I get nothing done at all. So better someone does it, than it doesn't happen. No worries. |
Replaces #100, which did not receive any updates for weeks.
Besides the expected changes concerning the actual version changes:
Adds therun.sh
for test runs as volume like it was done for the test run script. This allows easier changes during development and does not harm any production things. There is a little risk of not havingrun.sh
in the container and passing the CI anyways.