Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract mentoring CSS #6220

Merged
merged 5 commits into from
Sep 25, 2023
Merged

Extract mentoring CSS #6220

merged 5 commits into from
Sep 25, 2023

Conversation

iHiD
Copy link
Member

@iHiD iHiD commented Sep 21, 2023

@dem4ron Most of the automation CSS seems to be a duplicate of the inbox CSS. Do we need both? I think this CSS could probably be tidied a bit.

@iHiD
Copy link
Member Author

iHiD commented Sep 21, 2023

@dem4ron Are there any tooltips or components that can also be brought into here (they need to be only things that show to mentors - but they could be any page under exercism.org/mentoring except for the external page).

@dem4ron
Copy link
Member

dem4ron commented Sep 21, 2023

Yes, inbox and automation is almost the same. I copy-pasted it a year ago, it definitely can be cleaned up. Maybe create a c-list or c-table-with-rows or something for this kind of layout?

@iHiD
Copy link
Member Author

iHiD commented Sep 21, 2023

I added a missing file.

@iHiD iHiD force-pushed the extract-mentoring-css branch from 1cde5f8 to 06bd484 Compare September 25, 2023 12:21
@iHiD iHiD changed the base branch from extract-profile-css to main September 25, 2023 12:21
@iHiD iHiD merged commit 4ab26a8 into main Sep 25, 2023
@iHiD iHiD deleted the extract-mentoring-css branch September 25, 2023 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants