Align: Opt. request debug ouput only for first lane

f3sch · Nov 15, 2024 · 99577ca · 99577ca
1 parent 2121e45
commit 99577ca
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 8 deletions.
diff --git a/Detectors/Align/Workflow/src/BarrelAlignmentSpec.cxx b/Detectors/Align/Workflow/src/BarrelAlignmentSpec.cxx
@@ -107,7 +107,7 @@ class BarrelAlignmentSpec : public Task
   bool mIgnoreCCDBAlignment = false;
   bool mCosmic = false;
   bool mLoadTPCCalib = false;
-  int mLane = 0;
+  size_t mLane = 0;
   int mPostProcessing = 0; // special mode of extracting alignment or constraints check
   GTrackID::mask_t mMPsrc{};
   DetID::mask_t mDetMask{};
@@ -136,8 +136,8 @@ void BarrelAlignmentSpec::init(InitContext& ic)
   int dbg = ic.options().get<int>("debug-output");
   mLane = ic.services().get<const o2::framework::DeviceSpec>().inputTimesliceId;
   mController = std::make_unique<Controller>(mDetMask, mMPsrc, mCosmic, mUseMC, mLane);
-  if (dbg) {
-    mController->setDebugOutputLevel(dbg);
+  if (dbg > 0 || (dbg < 0 && mLane == 0)) {
+    mController->setDebugOutputLevel(std::abs(dbg));
   }
 
   mConfMacro = ic.options().get<std::string>("config-macro");
@@ -385,8 +385,8 @@ DataProcessorSpec getBarrelAlignmentSpec(GTrackID::mask_t srcMP, GTrackID::mask_
     ConfigParamSpec{"initial-params-file", VariantType::String, "", {"initial parameters file"}},
     ConfigParamSpec{"config-macro", VariantType::String, "", {"configuration macro with signature (o2::align::Controller*, int) to execute from init"}},
     ConfigParamSpec{"ignore-initial-params-errors", VariantType::Bool, false, {"ignore initial params (if any) errors for precondition"}},
-    ConfigParamSpec{"debug-output", VariantType::Int, 0, {"produce debugging output root files"}}};
-  if (!postprocess) {
+    ConfigParamSpec{"debug-output", VariantType::Int, 0, {"produce debugging output root files (>0 for all lanes; <0 only for first lane)"}}};
+  if (postprocess == 0) {
     dataRequest->requestTracks(src, useMC);
     dataRequest->requestClusters(src, false, skipDetClusters);
     dataRequest->requestPrimaryVertices(useMC);

diff --git a/Detectors/Align/include/Align/Controller.h b/Detectors/Align/include/Align/Controller.h
@@ -126,7 +126,7 @@ class Controller final : public TObject
          kMPAlignDone = BIT(16) };
 
   Controller() = default;
-  Controller(DetID::mask_t detmask, GTrackID::mask_t trcmask, bool cosmic = false, bool useMC = false, int instID = 0);
+  Controller(DetID::mask_t detmask, GTrackID::mask_t trcmask, bool cosmic = false, bool useMC = false, size_t instID = 0);
   ~Controller() final;
 
   void expandGlobalsBy(int n);
@@ -299,7 +299,7 @@ class Controller final : public TObject
   GTrackID::mask_t mMPsrc{};
   std::vector<int> mTrackSources;
   o2::framework::TimingInfo mTimingInfo{};
-  int mInstanceID = 0; // instance in case of pipelining
+  size_t mInstanceID = 0; // instance in case of pipelining
   int mRunNumber = 0;
   int mNDet = 0;  // number of deectors participating in the alignment
   int mNDOFs = 0; // number of degrees of freedom

diff --git a/Detectors/Align/src/Controller.cxx b/Detectors/Align/src/Controller.cxx
@@ -88,7 +88,7 @@ const Char_t* Controller::sDetectorName[Controller::kNDetectors] = {"ITS", "TPC"
 const int Controller::sSkipLayers[Controller::kNLrSkip] = {0, 0, 0, 0}; // TODO(milettri, shahoian): needs AliGeomManager - remove this line after fix.
 
 //________________________________________________________________
-Controller::Controller(DetID::mask_t detmask, GTrackID::mask_t trcmask, bool cosmic, bool useMC, int instID)
+Controller::Controller(DetID::mask_t detmask, GTrackID::mask_t trcmask, bool cosmic, bool useMC, size_t instID)
   : mDetMask(detmask), mMPsrc(trcmask), mUseMC(useMC), mInstanceID(instID)
 {
   setCosmic(cosmic);