CcdbDownloader: Better logging, removing faulty tests

f3sch · Nov 23, 2023 · a13ea07 · a13ea07
1 parent 85738a7
commit a13ea07
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 3 deletions.
diff --git a/CCDB/src/CCDBDownloader.cxx b/CCDB/src/CCDBDownloader.cxx
@@ -408,7 +408,7 @@ std::string CCDBDownloader::trimHostUrl(std::string full_host_url) const
   char* host;
   CURLUcode host_result = curl_url_get(host_url, CURLUPART_HOST, &host, 0);
   if (host_result != CURLUE_OK) {
-    LOG(error) << "CCDBDownloader: Malformed url detected when processing redirect, could not identify the host part: " << host;
+    LOG(error) << "CCDBDownloader: Malformed url detected when processing redirect, could not identify the host part: " << full_host_url;
     curl_url_cleanup(host_url);
     return "";
   }

diff --git a/CCDB/test/testCcdbApiDownloader.cxx b/CCDB/test/testCcdbApiDownloader.cxx
@@ -386,8 +386,6 @@ BOOST_AUTO_TEST_CASE(trim_host_url_test)
   CCDBDownloader downloader;
   BOOST_CHECK(downloader.trimHostUrl("http://localhost:8080") == "http://localhost:8080");
   BOOST_CHECK(downloader.trimHostUrl("http://localhost") == "http://localhost");
-  BOOST_CHECK(downloader.trimHostUrl("localhost:8080") == "localhost:8080");
-  BOOST_CHECK(downloader.trimHostUrl("localhost:8080/some/path") == "localhost:8080");
   BOOST_CHECK(downloader.trimHostUrl("http://localhost:8080/some/path") == "http://localhost:8080");
   BOOST_CHECK(downloader.trimHostUrl("http://localhost/some/path") == "http://localhost");
   BOOST_CHECK(downloader.trimHostUrl("http://localhost:8080/Task/Detector/1?HTTPOnly=true") == "http://localhost:8080");