AM Demod: Add additional modes to specify channel center frequency #1876
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently AM Demod channel center frequency is specified by Δf setting. This PR adds a couple of additional modes, that are selected by a combo box that replaces the Δf label:
Δf option uses current behaviour
25k - Allows entry of an absolute frequency specified in MHz (as is typical in the airband). This I think has two advantages:
The valuedial only displays 6 digits, as this is typically how airband frequencies are specified / spoken. Although not normally needed with AM, it's still possible to fine tune the demod center frequency to a higher precision than is displayed in the value dial, by dragging the channel marker. The precise frequency is shown at the bottom of the demod, as is currently the case.
By right clicking on the combo box, it's possible to enable snapping (combobox will be highlighted when snapping is enabled). This snaps the channel marker to 25kHz boundaries - this makes it much easier to tune accurately, when you have a wide bandwidth. For example, when bandwidth is >~2M (because you want to see activity across the spectrum), it's quite hard to accurately place the channel marker, as it's quite narrow.
8.33k - Allows entry of an 8.33kHz channel number, which is mapped to the appropriate frequency. E.g. 118.910 is mapped to 118,908,333Hz. This also supports snapping, but to 8.333kHz boundaries.
Also added a MW option, which allows specifying an absolute frequency in kHz.
Any other use cases you think might be useful?
If you like it, it could be something we added to some of the other demods too (i.e. being able to specify absolute frequencies + support snapping), where appropriate.
Patch also fixes a bug in ValueDialZ, that was preventing using the keyboard to enter the first digit, when m_positiveOnly was true.