Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to fix scope trigger #1902

Merged
merged 1 commit into from
Nov 25, 2023
Merged

Attempt to fix scope trigger #1902

merged 1 commit into from
Nov 25, 2023

Conversation

srcejon
Copy link
Collaborator

@srcejon srcejon commented Nov 24, 2023

This is a possible fix for #1901, but please review

Currently, the code in processTrace only ever appears to look at the first sample in a block of data

const Complex& s = *vbegin[triggerStreamIndex];

I'm guessing it needs to be indexed using processed (as that variable isn't read anywhere else in the loop)

const Complex& s = vbegin[triggerStreamIndex][processed];

And it seems to trigger more as I'd expect.

@f4exb
Copy link
Owner

f4exb commented Nov 25, 2023

This seems to make sense

@f4exb f4exb merged commit 7a71968 into f4exb:master Nov 25, 2023
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants