-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update custom app docs #230
Conversation
edgarriba
commented
Oct 30, 2023
•
edited
Loading
edited
6e7fb03
to
d61ea75
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but I did not exercise the workflow.
@OloFuchs can you exercise these docs (create and deploy the app template) the next time you're on?
Co-authored-by: Kyle Coble <53625197+Hackerman342@users.noreply.github.com>
Co-authored-by: Kyle Coble <53625197+Hackerman342@users.noreply.github.com>
|
||
## Quick Tips | ||
|
||
* The Amiga user is able to install APT packages. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These tips are nice but they seem a bit out of context here. When I start reading this, I'm not sure what the entry.sh
is or what a venv per application means.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that's an artifact from the old docs. Removing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wait -- this is from the old version that is not supported anymore. We can remove in follow up PR if that's allright @Hackerman342 @mihelich
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah this page is not rendered if it's not added to sidebars,js. No reason to keep around though because we can always find it in the git history