Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update custom app docs #230

Merged
merged 5 commits into from
Nov 3, 2023
Merged

update custom app docs #230

merged 5 commits into from
Nov 3, 2023

Conversation

edgarriba
Copy link
Member

@edgarriba edgarriba commented Oct 30, 2023

Screenshot from 2023-11-02 11-29-03

@edgarriba edgarriba force-pushed the update-custom-app-docs branch from 6e7fb03 to d61ea75 Compare October 30, 2023 14:56
@edgarriba edgarriba changed the title [wip] update custom app docs update custom app docs Nov 2, 2023
@edgarriba edgarriba marked this pull request as ready for review November 2, 2023 10:27
Copy link
Collaborator

@Hackerman342 Hackerman342 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I did not exercise the workflow.

@OloFuchs can you exercise these docs (create and deploy the app template) the next time you're on?

website/docs/brain/custom-applications.mdx Outdated Show resolved Hide resolved
website/docs/brain/custom-applications.mdx Outdated Show resolved Hide resolved
edgarriba and others added 2 commits November 2, 2023 17:20
Co-authored-by: Kyle Coble <53625197+Hackerman342@users.noreply.github.com>
Co-authored-by: Kyle Coble <53625197+Hackerman342@users.noreply.github.com>

## Quick Tips

* The Amiga user is able to install APT packages.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These tips are nice but they seem a bit out of context here. When I start reading this, I'm not sure what the entry.sh is or what a venv per application means.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's an artifact from the old docs. Removing

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wait -- this is from the old version that is not supported anymore. We can remove in follow up PR if that's allright @Hackerman342 @mihelich

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah this page is not rendered if it's not added to sidebars,js. No reason to keep around though because we can always find it in the git history

@edgarriba edgarriba merged commit 72e92f8 into main Nov 3, 2023
2 checks passed
@edgarriba edgarriba deleted the update-custom-app-docs branch November 3, 2023 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants