Skip to content

Commit

Permalink
Bump ubuntu and macos runner versions across CI.
Browse files Browse the repository at this point in the history
Use supported runners that still support Python 3.8, matching the
system Python on the Brain.
  • Loading branch information
mihelich committed Dec 16, 2024
1 parent 21dce0f commit c95dc7e
Show file tree
Hide file tree
Showing 8 changed files with 19 additions and 20 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/api_reference.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ jobs:
runs-on: ${{ matrix.os }}
strategy:
matrix:
os: [ubuntu-20.04]
os: [ubuntu-22.04]
fail-fast: false


Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,13 +20,13 @@ jobs:
strategy:
matrix:
include:
- os: ubuntu-20.04
- os: ubuntu-22.04
compiler: gcc
asan: off
- os: ubuntu-20.04
- os: ubuntu-22.04
compiler: clang
asan: off
- os: ubuntu-20.04
- os: ubuntu-22.04
compiler: clang
asan: on

Expand All @@ -41,7 +41,7 @@ jobs:
working-directory: ./scripts
run: |
./install_deps_ubuntu.sh
if: matrix.os == 'ubuntu-20.04'
if: matrix.os == 'ubuntu-22.04'

- name: Download dependencies (proto)
run: |
Expand Down
9 changes: 4 additions & 5 deletions .github/workflows/ci_python.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,11 +14,10 @@ jobs:
strategy:
fail-fast: false
matrix:
# Using macos-12 bc:
# 1. they removed support for python 3.8 & 3.9 on macos-14 (now macos-latest)
# - See: https://github.com/actions/setup-python/issues/696#issuecomment-2071769156
# 2. `test_pose` fails on macos-13 and macos-14 (but not macos-12)
os: [ubuntu-20.04, macos-12]
# We use ubuntu-22.04 and macos-13 because they are the final Github runner images
# with Python 3.8 pre-installed. Brain OS images based on Jetpack 5 use 3.8 as the
# system Python, so we want to test 3.8 even though it is EOL.
os: [ubuntu-22.04, macos-13]
python-version: ['3.8', '3.9', '3.10', '3.11', '3.12']
steps:
- uses: actions/checkout@v4
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/docs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ on:
jobs:
deploy:
name: Deploy to GitHub Pages
runs-on: ubuntu-20.04
runs-on: ubuntu-22.04
steps:
- uses: actions/checkout@v2
with:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/format.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ concurrency:

jobs:
pre-commit-check:
runs-on: ubuntu-20.04
runs-on: ubuntu-22.04
steps:
- uses: actions/checkout@v3
- uses: actions/setup-python@v3
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/pypi-release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ jobs:
strategy:
fail-fast: false
matrix:
os: [ubuntu-20.04, macos-12]
os: [ubuntu-22.04, macos-13]
steps:
- uses: actions/checkout@v4
with:
Expand Down Expand Up @@ -41,7 +41,7 @@ jobs:

build_sdist:
name: Build source distribution
runs-on: ubuntu-20.04
runs-on: ubuntu-22.04
steps:
- uses: actions/checkout@v4
- name: Build sdist
Expand All @@ -52,7 +52,7 @@ jobs:

upload_pypi:
needs: [build_wheels, build_sdist]
runs-on: ubuntu-20.04
runs-on: ubuntu-22.04
if: github.event_name == 'release' && github.event.action == 'published'
steps:
- uses: actions/download-artifact@v3
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ jobs:
# Based on https://dev.to/eugenebabichenko/automated-multi-platform-releases-with-github-actions-1abg
create_release:
name: Create Release and Provide Upload URL.
runs-on: ubuntu-20.04 # OS to create release, not for build
runs-on: ubuntu-22.04 # OS to create release, not for build
outputs:
# This job will provide URL for build jobs to use for uploading assets
upload_url: ${{ steps.create_release.outputs.upload_url }}
Expand All @@ -39,7 +39,7 @@ jobs:
runs-on: ${{ matrix.os }}
strategy:
matrix:
os: [ubuntu-20.04]
os: [ubuntu-22.04]
fail-fast: false

steps:
Expand All @@ -49,7 +49,7 @@ jobs:

- name: Install system dependencies (Ubuntu)
run: ./scripts/install_deps_ubuntu.sh
if: matrix.os == 'ubuntu-20.04'
if: matrix.os == 'ubuntu-22.04'

- name: Install venv dependencies
run: ./scripts/build_venv/build_venv.sh
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/rs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ jobs:
strategy:
matrix:
include:
- os: ubuntu-20.04
- os: ubuntu-22.04
fail-fast: false
steps:
- uses: actions/checkout@v3
Expand All @@ -24,7 +24,7 @@ jobs:
working-directory: ./scripts
run: |
./install_deps_ubuntu.sh
if: matrix.os == 'ubuntu-20.04'
if: matrix.os == 'ubuntu-22.04'

- name: Download dependencies (proto)
run: |
Expand Down

0 comments on commit c95dc7e

Please sign in to comment.