Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix pre-commit check / format.yml workflow #206

Merged
merged 5 commits into from
Jan 16, 2024
Merged

Fix pre-commit check / format.yml workflow #206

merged 5 commits into from
Jan 16, 2024

Conversation

Hackerman342
Copy link
Collaborator

No description provided.

@Hackerman342 Hackerman342 changed the title Update format.yml workflow Fix pre-commit check / format.yml workflow Jan 16, 2024
@Hackerman342
Copy link
Collaborator Author

Hackerman342 commented Jan 16, 2024 •
edited
Loading

Found this issue that is exactly what we have going on: python/mypy#16767

Solution from that issue (while mypy fixes things) is done in 9408a98

@Hackerman342 Hackerman342 marked this pull request as ready for review January 16, 2024 23:52
@Hackerman342 Hackerman342 merged commit 69e1ddd into main Jan 16, 2024
11 checks passed
@Hackerman342 Hackerman342 deleted the update-format-ci branch January 16, 2024 23:54
strasdat pushed a commit that referenced this pull request Jun 2, 2024
@Hackerman342 @strasdat
Fix pre-commit check / format.yml workflow (#206)
f11301d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mihelich mihelich Awaiting requested review from mihelich

@edgarriba edgarriba Awaiting requested review from edgarriba

@guilhermedemouraa guilhermedemouraa Awaiting requested review from guilhermedemouraa

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Hackerman342