Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix check-not-logged logic #1051

Merged
merged 20 commits into from
Dec 18, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions docs/specs/sequences/generated.md
Original file line number Diff line number Diff line change
Expand Up @@ -365,14 +365,14 @@ Check that the device correctly handles an extra out-of-schema field
1. Wait for last_config not null
1. Wait for system operational
1. Check that system status level is not >= `WARNING` (400)
1. Update config Before system logs level `DEBUG` category `system.config.receive`
1. Update config before system logs level `DEBUG` category `system.config.receive`
1. Wait until system logs level `DEBUG` category `system.config.receive`
1. Wait for last_config updated
1. Wait until last_config updated
1. Wait for system operational
1. Check that system status level is not >= `WARNING` (400)
1. Wait until system logs level `DEBUG` category `system.config.parse`
1. Wait until system logs level `NOTICE` category `system.config.apply`
1. Update config Before system logs level `DEBUG` category `system.config.receive`
1. Update config before system logs level `DEBUG` category `system.config.receive`
1. Wait until system logs level `DEBUG` category `system.config.receive`
1. Wait for last_config updated again
1. Wait for system operational
Expand Down Expand Up @@ -462,7 +462,7 @@ Test passed.

Check error when pointset configuration contains extraneous point

1. Update config Before pointset state matches config
1. Update config before pointset state matches config
* Add `pointset.sample_rate_sec` = `10`
1. Wait until pointset state matches config
1. Wait until pointset event contains correct points
Expand Down Expand Up @@ -505,7 +505,7 @@ Check results of a single scan scheduled soon
1. Wait for discovery families defined
1. Wait until discovery family keys match
1. Wait for no scans active
1. Update config Before scheduled scan pending
1. Update config before scheduled scan pending
* Add `discovery.families.vendor` = { "generation": `family generation`, "scan_duration_sec": `10` }
1. Wait until scheduled scan pending
1. Wait until scheduled scan active
Expand All @@ -529,7 +529,7 @@ Check results of a single scan scheduled in the recent past
1. Wait for discovery families defined
1. Wait until discovery family keys match
1. Wait for no scans active
1. Update config Before scheduled scan active
1. Update config before scheduled scan active
* Add `discovery.families.vendor` = { "generation": `family generation`, "scan_duration_sec": `10` }
1. Wait until scheduled scan active
1. Check that scan started at time
Expand All @@ -552,7 +552,7 @@ Check that a scan scheduled in the past never starts
1. Wait for discovery families defined
1. Wait until discovery family keys match
1. Wait for no scans active
1. Update config Before scan schedule initially not active
1. Update config before scan schedule initially not active
* Add `discovery.families.vendor` = { "generation": `family generation`, "scan_duration_sec": `10` }
1. Wait until scan schedule initially not active
1. Wait until scan schedule still not active
Expand Down
1 change: 1 addition & 0 deletions etc/schema_itemized.out
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
1 writeback_success
1 writeback_success
1 pointset_publish_interval
1 system_min_loglevel
1 system_mode_restart
1 config_logging
1 broken_config RESULT fail schemas device_state_stable STABLE 10/10 Schema violations found
Expand Down
1 change: 1 addition & 0 deletions etc/test_itemized.in
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ TEST writeback_success extraPoint=filter_differential_pressure_setpoint
TEST writeback_success noWriteback
TEST writeback_success noPointState
TEST pointset_publish_interval fixedSampleRate=10
TEST system_min_loglevel fixedLogLevel=100
TEST system_mode_restart noPersist
TEST config_logging badVersion
TEST broken_config barfConfig
Expand Down
1 change: 1 addition & 0 deletions etc/test_itemized.out
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
1 RESULT fail writeback writeback_success ALPHA 0/10 Failed waiting until target point to have value_state applied
1 RESULT fail writeback writeback_success ALPHA 0/10 Failed waiting until target point to have value_state applied
1 RESULT fail pointset pointset_publish_interval STABLE 0/10 Failed check that time period between successive pointset events is between 5 and 8 seconds
1 RESULT fail system system_min_loglevel ALPHA 0/10 Failed check that log level `NOTICE` (or greater) category `system.config.apply` was not logged
1 RESULT fail system.mode system_mode_restart ALPHA 0/10 Failed check that restart count increased by one
1 RESULT fail system config_logging STABLE 0/10 Failed waiting until config update synchronized
1 CPBLTY fail system broken_config.logging ALPHA 0/1 Failed waiting until (logging) system logs level `DEBUG` category `system.config.receive`
Expand Down
4 changes: 2 additions & 2 deletions validator/sequences/extra_config/config_update.attr

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

17 changes: 11 additions & 6 deletions validator/sequences/extra_config/config_update.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading