fix: forcing variation with variable overrides #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
polok
commented
Jan 4, 2024
| if let matchedAllocation = matchedTrafficAndAllocation.matchedAllocation { | ||
| var variationValue: VariationValue? = nil | ||
|
|
||
| if let forceVariation = force?.variation { |
There was a problem hiding this comment.
these lines are the fix
fahad19
approved these changes
Jan 4, 2024
PatrykPiwowarczyk
approved these changes
Jan 4, 2024
FranciszekCzana
approved these changes
Jan 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Forcing:
The issue
When forcing a variation from rules, without forcing variables, the forced variation is not honored when evaluating its variables.
The fix
When evaluating variables, it will now check if there happens to be any forced variation.
If any forced variation, it will then honor the variation value before evaluating the variable values.
Otherwise, it will continue with its regular bucketing logic.
Note
The issue was spotted under JS SDK where Swift SDK follows it. As a reference featurevisor/featurevisor#236