refactor: performance tweaks under DatafileReader
#68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
P-Jag
approved these changes
Apr 2, 2024
Rolfrider
approved these changes
Apr 2, 2024
| @@ -24,18 +30,18 @@ public class DatafileReader { | |||
| } | |||
|
|
|||
| public func getAllAttributes() -> [Attribute] { | |||
| return self.attributes | |||
| return Array(attributes.values) | |||
There was a problem hiding this comment.
It's a small improvement (if any) but you can also consider returning here sequence, so you don't need to create new Array
There was a problem hiding this comment.
Let's replace arrays with dictionaries under this PR. I believe that is not the last PR like this.
PatrykPiwowarczyk
approved these changes
Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dictionaries provide constant, i.e. O(1), access, which means searching if a value exists and updating it, is faster than with an Array, which, depending on implementation can be O(n). Under DatafileReader we use search very often yo find attributes, segments and features.