Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

releng: tito --test builds to have higher NVRs than released versions #3576

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

praiskup
Copy link
Member

@praiskup praiskup commented Jan 6, 2025

Historically, Tito only modified the Release tag for --test builds. Now, we also bump the Version field to ensure that Mock built from Git revisions always has a higher NVR than (previously) released packages.

https://github.com/rpm-software-management/tito/releases/tag/tito-0.6.27-1

Historically, Tito only modified the Release tag for `--test` builds.
Now, we also bump the Version field to ensure that Mock built from Git
revisions always has a higher NVR than (previously) released packages.

https://github.com/rpm-software-management/tito/releases/tag/tito-0.6.27-1
@@ -4,3 +4,4 @@ tagger = tito.tagger.VersionTagger
changelog_do_not_remove_cherrypick = 0
changelog_format = %s
fetch_sources = True
test_version_suffix = .test
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: would .git be better?

Copy link
Member Author

@praiskup praiskup Jan 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The difference would be:

/tmp/tito/copr-backend-2.1.test-1.git.38.3719a4f.fc41.src.rpm
/tmp/tito/copr-backend-2.1.git-1.git.38.3719a4f.fc41.src.rpm

No big deal - I can fix, just note there's the double-git part git-1.git.

@praiskup praiskup merged commit ddec4d9 into fedora-copr:main Jan 7, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants