Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Added experimental terminal integration #13631

Draft
wants to merge 79 commits into
base: main
Choose a base branch
from
Draft

Feature: Added experimental terminal integration #13631

wants to merge 79 commits into from

Conversation

gave92
Copy link
Member

@gave92 gave92 commented Nov 1, 2023 •
edited
Loading

Resolved / Related Issues

  • Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
    Closes Feature: Add terminal Integration #6235

Validation
How did you test these changes?

  • Did you build the app and test your changes?

Screenshots (optional)
image

@files-community files-community locked and limited conversation to collaborators Nov 1, 2023
@gave92
Copy link
Member Author

gave92 commented Jun 19, 2024

Lol yeah completely new projects just for having rounded corners xD I do hope MS will add this to standard webview.

@gave92
Copy link
Member Author

gave92 commented Jun 21, 2024 •
edited
Loading

I don't suppose you'd be ok at least temporarily with this? 😇 Only way I could find that does not require using WebView2Ex.
image

@yaira2
Copy link
Member

yaira2 commented Jun 21, 2024

I won't mention it for now 😂

@yaira2
Switch status bar with terminal
d6e432e 
Revert "Switch status bar with terminal"

This reverts commit 8d793ed.

Update MainPage.xaml

Revert "Switch status bar with terminal"

This reverts commit 248347a.

Update StatusBar.xaml
@yaira2 yaira2 force-pushed the main branch 2 times, most recently from ff65c93 to 8097ba8 Compare July 17, 2024 15:22
Lamparter
Lamparter approved these changes Oct 17, 2024
View reviewed changes
Copy link
Contributor

@Lamparter Lamparter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the merge conflicts, what's stopping this from being merged? Was there something else to implement or is it not stable enough?

@yaira2
Copy link
Member

yaira2 commented Oct 27, 2024

Functionality wise this is pretty much good to go, but we haven't settled on a design yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XTorLukas XTorLukas XTorLukas requested changes

@0x5bfa 0x5bfa 0x5bfa left review comments

@gumbarros gumbarros gumbarros left review comments

@yaira2 yaira2 yaira2 left review comments

@Lamparter Lamparter Lamparter approved these changes

At least 1 approving review is required to merge this pull request.

Assignees

@yaira2 yaira2

Labels
needs - code review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature: Add terminal Integration
7 participants
@gave92 @hez2010 @0x5bfa @yaira2 @gumbarros @Lamparter @XTorLukas