Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Quality: Removed Vanara from IStorageNetworkService #16234

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

0x5bfa
Copy link
Member

@0x5bfa 0x5bfa commented Sep 21, 2024

Resolved / Related Issues

Steps used to test these changes

  • Go to Home
  • Enable Network section
  • See the enumerated network computers and shortcuts

@0x5bfa 0x5bfa force-pushed the 5bfa/CQ-IStorageNetworkServiceVanara branch 2 times, most recently from cc0c966 to c7ac2d3 Compare September 22, 2024 06:38
@0x5bfa 0x5bfa force-pushed the 5bfa/CQ-IStorageNetworkServiceVanara branch from b193542 to c420f19 Compare September 24, 2024 22:45
@0x5bfa
Copy link
Member Author

0x5bfa commented Oct 10, 2024

There's no memory leak here as far as I can tell.
I'd like this to be reviewed by @hishitetsu as I have no network PC or shortcut.

@hishitetsu
Copy link
Member

I will test it when I have time. But if you make a local folder shared, you will be able to access that folder by UNC path, so you can also test without a network PC.

@0x5bfa
Copy link
Member Author

0x5bfa commented Oct 11, 2024

Somehow the share menu is grayed out and I can't reenable even tho I messed around Group Policy and some settings.

@yaira2
Copy link
Member

yaira2 commented Oct 28, 2024

@0x5bfa have you looked into this issue further?

@0x5bfa
Copy link
Member Author

0x5bfa commented Nov 7, 2024

@0x5bfa have you looked into this issue further?

I cant test it anyways

@yaira2
Copy link
Member

yaira2 commented Nov 7, 2024

But if you make a local folder shared, you will be able to access that folder by UNC path, so you can also test without a network PC.

@0x5bfa
Copy link
Member Author

0x5bfa commented Nov 7, 2024

Like mentioned, the option (Share) is grayed out somehow and I tried to make it clickable by looking into Group Policy and some other Windows Settings, and didn't work.

Either way, it's fine as is if I should test (idk how to).

@yaira2 yaira2 requested a review from hishitetsu November 26, 2024 20:49
@Josh65-2201
Copy link
Member

Josh65-2201 commented Nov 26, 2024

I have found a few issues.

  • Mapped network drives won't show when starting Files but will for new mapped ones.
  • Opening them any way other then continue where you left off setting will cause a crash debug.log
  • Devices are shown in the sidebar that shouldn't be (no storage support like Smart TV's)

@0x5bfa 0x5bfa marked this pull request as draft December 10, 2024 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants