Code Quality: Enforced code style in EditorConfig #16441
+100
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@0x5bfa what do you think? |
0x5bfa
approved these changes
Nov 19, 2024
| dotnet_naming_symbols.constants.required_prefix = | ||
| dotnet_naming_symbols.constants.required_suffix = | ||
| dotnet_naming_symbols.constants.required_capitalization = all_upper |
There was a problem hiding this comment.
I think Pascal is fine. Title case is used in C/C++
There was a problem hiding this comment.
Wait, we require this. The normal C# convention is to use PascalCase for constants, we should amend.
There was a problem hiding this comment.
Sorry, you mean use PascalCase here? I don't understand
The docs literally say use UPPER for constant variables.
| dotnet_naming_rule.camel_case_for_parameters.style = camel_case | ||
| dotnet_naming_rule.pascal_case_for_properties.style = pascal_case | ||
| dotnet_naming_rule.upper_case_for_constants.style = all_upper |
0x5bfa
added
changes requested
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved / Related Issues
Steps used to test these changes
N/A
More details are coming soon!