Code Quality: Refactored the code for Quick Access #16485
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0x5bfa
force-pushed
the
5bfa/CQ-QuickAccessRefactor
branch
from
0fabe5a to
2dbf6f4
Compare
0x5bfa
force-pushed
the
5bfa/CQ-QuickAccessRefactor
branch
from
0c973ed to
2ebb917
Compare
yaira2
reviewed
Nov 28, 2024
| @@ -96,7 +96,8 @@ protected override void OnNavigatedTo(NavigationEventArgs eventArgs) | |||
|
|
|||
| if (!string.IsNullOrEmpty(pathRoot)) | |||
| { | |||
| var rootPathList = App.QuickAccessManager.Model.PinnedFolders.Select(NormalizePath) | |||
| var service = Ioc.Default.GetRequiredService<IQuickAccessService>(); | |||
There was a problem hiding this comment.
Shouldn't the service be defined at the top of the class?
yaira2
reviewed
Nov 28, 2024
yaira2
changed the title
yaira2
reviewed
Dec 11, 2024
yaira2
reviewed
Dec 11, 2024
| Task SaveAsync(string[] items); | ||
| IReadOnlyList<INavigationControlItem> Folders { get; } | ||
|
|
||
| event EventHandler<NotifyCollectionChangedEventArgs>? PinnedFoldersChanged; |
There was a problem hiding this comment.
Is this event limited to pinned folders, or does it also notify when recent folders are added to the list?
|
The most recent test I ran on this branch had an issue where pinned folders weren't displaying in the sidebar. |
yaira2
added
changes requested
|
This isn't really ready for review yet. I need to make the update pinned files async to return the pinned files and create a file notifier for the pinned files folder to use it in sidebar and the widget. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved / Related Issues
Steps used to test these changes