Code Quality: Migrated shared properties to props file #16557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
I have absolutely no idea how to do that so hope this works
Lamparter
changed the title
Directory.Build.propsDirectory.Build.props
Lamparter
changed the title
Directory.Build.props
|
LGTM |
|
Can you please rebase from |
yaira2
reviewed
Dec 10, 2024
yaira2
reviewed
Dec 10, 2024
|
We're currently facing an issue where the x86 and ARM64 configurations are displaying an error for 'incorrect configurations'. |
yaira2
added
changes requested
yaira2
added
needs - code review
and removed
changes requested
|
I think Files.sln got messed up but we should recreate a new .sln and add one by one. One more concern is Win32 configuration; we should have named it x86. However, for now, as far as current solution file doesn't cause configuration issue, LGTM. |
|
Once this PR is merged, I'll create a completely new solution file in another PR and you can review. |
|
I have a pr that simplify the configurations of the c++ projects, so let's wait it too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved / Related Issues
Steps used to test these changes
Built the app; checked for Roslyn analyser warnings
This PR finally adds a props file to manage mutual properties where appropriate. It has been built and tested and works perfectly.
I also wanted to implement CPM however haven't succeeded yet.