Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NuGet: Added metadata to the Controls project to enable publishing to NuGet #16611

Open
wants to merge 19 commits into
base: main
Choose a base branch
from
Open

NuGet: Added metadata to the Controls project to enable publishing to NuGet #16611

wants to merge 19 commits into from

Conversation

Lamparter
Copy link
Contributor

Resolved / Related Issues

Discussed on Discord

Steps used to test these changes

  1. Built the Files controls project
  2. Checked for Roslyn analysers during build
  3. Ensured NuGet package was correctly generated
  4. Inspected NuGet package internals to ensure proper generation and inclusion of XAML resources

@Lamparter Lamparter marked this pull request as ready for review December 24, 2024 19:04
@Lamparter Lamparter requested a review from yaira2 December 24, 2024 19:04
@Lamparter
Copy link
Contributor Author

Note for reviewer:
image
The CD fails because there is no such API key provided (please create a NUGET_API_KEY secret in the repository to enable publishing)

@yaira2 yaira2 changed the title Added package metadata to controls project to enable publishing Nuget: Added metadata to the Controls project to enable publishing to Nuget Dec 24, 2024
@Lamparter Lamparter changed the title Nuget: Added metadata to the Controls project to enable publishing to Nuget NuGet: Added metadata to the Controls project to enable publishing to Nuget Dec 24, 2024
@Lamparter Lamparter changed the title NuGet: Added metadata to the Controls project to enable publishing to Nuget NuGet: Added metadata to the Controls project to enable publishing to NuGet Dec 24, 2024
@Lamparter @yaira2
Move comma
e7d756b 
Co-authored-by: Yair <39923744+yaira2@users.noreply.github.com>
Lamparter and others added 2 commits December 24, 2024 20:43
@Lamparter @yaira2
Move comma in README.md
849d610 
Co-authored-by: Yair <39923744+yaira2@users.noreply.github.com>
@Lamparter @yaira2
Add more tags
40be6eb 
Co-authored-by: Yair <39923744+yaira2@users.noreply.github.com>
@Lamparter Lamparter requested a review from yaira2 December 24, 2024 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaira2 yaira2 Awaiting requested review from yaira2

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
needs - code review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Lamparter @yaira2