Move more commands from BaseLayout to BaseLayoutCommandsViewModel #4218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
d2dyno1
changed the title
|
Ready! |
yaira2
reviewed
Mar 30, 2021
yaira2
previously approved these changes
Mar 30, 2021
|
@d2dyno1 Great work! |
yaira2
reviewed
Mar 31, 2021
yaira2
reviewed
Mar 31, 2021
yaira2
approved these changes
Mar 31, 2021
yaira2
added
ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved / Related Issues
This PR is an ongoing work to improve Files' codebase and implement MVVM pattern. For #4180
Details of Changes
This PR moves some functions out of
BaseLayoutand implements them inBaseLayoutCommandsViewModelValidation
How did you test these changes?