-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for PHP 7.4 #113
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #113 +/- ##
========================================
Coverage 100% 100%
Complexity 267 267
========================================
Files 49 49
Lines 701 700 -1
========================================
- Hits 701 700 -1
Continue to review full report at Codecov.
|
@howard What do you think about dropping support for 1.x branch? |
@mmachatschek 1.x is still in active use for some shop system plugins that have a very old PHP version baseline, so it's not time to do that yet. Please limit the changes to what's necessary to make libflexport (2.x) compatible with PHP 7.4, without traces of introducing a new major version. That's a new topic that will soon get its own milestone issue to collect ideas and outline the plan for libflexport 3.0. |
@mmachatschek Your input for libflexport 3.0 is welcome in #114. |
@howard I updated the code again. I added support for PHP 7.1, as we would need to release a major version if we drop PHP 7.1? If not, please tell me. I would gladly update the code again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mmachatschek PHP 7.1 is still part of our compatibility matrix, and based on known PHP versions used by customers, it will remain supported, for 2.x at least.
Purpose
Change travis configuration and add support for PHP 7.4
Open Questions and Pre-Merge TODOs
composer lint
andcomposer fix
was executed.A issue with a detailed explanation of the problem/enhancement was created and linked.