Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for PHP 7.4 #113

Merged
merged 4 commits into from
Dec 31, 2019
Merged

Add support for PHP 7.4 #113

merged 4 commits into from
Dec 31, 2019

Conversation

mmachatschek
Copy link
Contributor

@mmachatschek mmachatschek commented Dec 14, 2019

Purpose

Change travis configuration and add support for PHP 7.4

Open Questions and Pre-Merge TODOs

  • composer lint and composer fix was executed.
  • Tests were written and pass with 100% coverage.
  • A issue with a detailed explanation of the problem/enhancement was created and linked.

@codecov-io
Copy link

codecov-io commented Dec 14, 2019

Codecov Report

Merging #113 into develop will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##             develop   #113   +/-   ##
========================================
  Coverage        100%   100%           
  Complexity       267    267           
========================================
  Files             49     49           
  Lines            701    700    -1     
========================================
- Hits             701    700    -1
Impacted Files Coverage Δ Complexity Δ
...rt/Exceptions/EmptyElementsNotAllowedException.php 100% <100%> (ø) 1 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9cc5c3e...0f6edb0. Read the comment docs.

@mmachatschek
Copy link
Contributor Author

@howard What do you think about dropping support for 1.x branch?

@howard
Copy link
Collaborator

howard commented Dec 16, 2019

@mmachatschek 1.x is still in active use for some shop system plugins that have a very old PHP version baseline, so it's not time to do that yet.

Please limit the changes to what's necessary to make libflexport (2.x) compatible with PHP 7.4, without traces of introducing a new major version. That's a new topic that will soon get its own milestone issue to collect ideas and outline the plan for libflexport 3.0.

@howard
Copy link
Collaborator

howard commented Dec 16, 2019

@mmachatschek Your input for libflexport 3.0 is welcome in #114.

@mmachatschek
Copy link
Contributor Author

mmachatschek commented Dec 17, 2019

@howard I updated the code again. I added support for PHP 7.1, as we would need to release a major version if we drop PHP 7.1? If not, please tell me. I would gladly update the code again.

Copy link
Collaborator

@howard howard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mmachatschek PHP 7.1 is still part of our compatibility matrix, and based on known PHP versions used by customers, it will remain supported, for 2.x at least.

@howard howard merged commit e112c28 into findologic:develop Dec 31, 2019
@mmachatschek mmachatschek deleted the php_74 branch February 22, 2020 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants