add a comment

src/refiners/training_utils/trainer.py

@@ -304,6 +304,9 @@ def backward(self) -> None:
             self.optimizer.zero_grad()
             self._call_callbacks(event_name="on_optimizer_step_end")
             if self.clock.is_due(self.config.lr_scheduler.update_interval):
+                # TODO: if the update interval is in Epochs, this will be called
+                # at every optimizer step during targeted epochs. It should probably
+                # only be called once instead.
                 self._call_callbacks(event_name="on_lr_scheduler_step_begin")
                 self.lr_scheduler.step()
                 self._call_callbacks(event_name="on_lr_scheduler_step_end")