Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make refiners.conversion.utils.Hub.expected_sha256 optional #474

Merged
merged 2 commits into from
Nov 12, 2024

Conversation

Laurent2916
Copy link
Member

@Laurent2916 Laurent2916 commented Nov 6, 2024

This way you can use a Hub object without specifying the hash, useful when declaring where to find a weight on the hub (since there is no need to check the hash).

@Laurent2916 Laurent2916 requested a review from deltheil November 6, 2024 16:59
@Laurent2916 Laurent2916 self-assigned this Nov 6, 2024
@Laurent2916 Laurent2916 force-pushed the make_hub_expected_hash_optional branch from d4c4676 to 6b87778 Compare November 6, 2024 17:03
Copy link
Member

@deltheil deltheil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please take a look

src/refiners/conversion/utils.py Show resolved Hide resolved
src/refiners/conversion/utils.py Outdated Show resolved Hide resolved
@Laurent2916 Laurent2916 force-pushed the make_hub_expected_hash_optional branch from 6b87778 to 432a6ff Compare November 12, 2024 12:51
@Laurent2916 Laurent2916 force-pushed the make_hub_expected_hash_optional branch from 432a6ff to c6acefe Compare November 12, 2024 13:09
@Laurent2916 Laurent2916 requested a review from deltheil November 12, 2024 13:09
@Laurent2916 Laurent2916 force-pushed the make_hub_expected_hash_optional branch from c6acefe to 409bec4 Compare November 12, 2024 13:27
@Laurent2916 Laurent2916 requested a review from deltheil November 12, 2024 13:28
@Laurent2916 Laurent2916 merged commit 32ce4fe into main Nov 12, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants