Tests: reuse network namespaces #4966
Open
+96
−60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Re-using namespaces saves a whole minute of the test run: before: 302 passed, 25 skipped in 303.29s (0:05:03) after: 301 passed, 25 skipped in 241.77s (0:04:01) Signed-off-by: Pablo Barbáchano <pablob@amazon.com>
Now that there are no bottlenecks we can increase the concurrency of the tests. TBD Test run from X to Y (%) before after Signed-off-by: Pablo Barbáchano <pablob@amazon.com>
Remove unused import Signed-off-by: Pablo Barbáchano <pablob@amazon.com>
pb8o
added
Priority: Low
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4966 +/- ##
=======================================
Coverage 83.93% 83.93%
=======================================
Files 248 248
Lines 27791 27791
=======================================
Hits 23327 23327
Misses 4464 4464
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Reuse network namespaces. This avoids spending time creating network devices and namespaces, which is a slow operation because of networking lock contention.
Also since we don't have lock contention, we can double the number of test workers and see an improvement.
Reason
To make functional test runs faster. Though this is low priority and the functional tests are not the long pole, this change is relatively small and self-contained.
The 2 changes together almost half the execution time:
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
tools/devtool checkstyleto verify that the PR passes theautomated style checks.
how they are solving the problem in a clear and encompassing way.
in the PR.
CHANGELOG.md.Runbook for Firecracker API changes.
integration tests.
TODO.rust-vmm.