feat: make World only ever require &self. #270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zicklag
force-pushed
the
feat/ref-only-world
branch
from
dba9cc4 to
28f85e3
Compare
This is wide but relatively shallow update that makes `World` only ever require `&self`, allowing us to remove the system initialization stage that was necessary to have `&mut World` access for initializing resources and components. The main change was to allow `Resources` to have resources added to it with only a `&self` reference by using a `once_map` internally. This meant that all resource cells now become `Option<SchemaBox>` on the inside. This conceptually means that cells for reasources are lazily initialized and always considered to be present, but they may or may not actually contain a resource value.
zicklag
force-pushed
the
feat/ref-only-world
branch
from
28f85e3 to
2a68926
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is wide but relatively shallow update that makes
Worldonly ever require&self, allowing us to remove the system initialization stage that was necessary to have&mut Worldaccess for initializing resources and components.The main change was to allow
Resourcesto have resources added to it with only a&selfreference by using aonce_mapinternally. This meant that all resource cells now becomeOption<SchemaBox>on the inside. This conceptually means that cells for reasources are lazily initialized and always considered to be present, but they may or may not actually contain a resource value.