Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat] Add type hints #251

Open
wants to merge 20 commits into
base: develop
Choose a base branch
from
Open

[Feat] Add type hints #251

wants to merge 20 commits into from

Conversation

fjosw
Copy link
Owner

@fjosw fjosw commented Dec 25, 2024

As a first step towards adding type hints, I added automatic type hints with monkeytype. Hints for the more complicated methods will need additional manual work but for the simpler methods this seems to have worked quite well.

@fjosw fjosw marked this pull request as ready for review January 3, 2025 18:12
@fjosw
Copy link
Owner Author

fjosw commented Jan 3, 2025

Not quite done but already in decent shape for a review @s-kuberski @jkuhl-uni:

  • Most of the changes are just type annotations
  • I changed a few lines to help mypy with understanding the type annotations
  • I fixed a few smaller bugs in which explicit type checks were not consistent or did not cover certain edge cases

For now I ignored the input/* modules and most of correlators.py, the remaining modules only raise a few smaller mypy errors which I wasn't able to fix right away.

@s-kuberski
Copy link
Collaborator

Great, thanks a lot for all of your work! I'll have a look in the upcoming week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants