Skip to content

Commit

Permalink
Added KIT to internal URLs regex, other minor improvements to the int…
Browse files Browse the repository at this point in the history
…ernal urls regex
  • Loading branch information
fjwillemsen committed Sep 5, 2022
1 parent b47b8f9 commit 4ddeb34
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ Using [nativefier](https://github.com/nativefier/nativefier), the Overleaf websi
If you have any problem running the app not fixed with these instructions, please [comment on or open an issue](https://github.com/fjwillemsen/NativeOverleaf/issues)!

### Institutional login
This has been fixed in v1.4.0. If you encounter a related issue, look at [issue #3](https://github.com/fjwillemsen/NativeOverleaf/issues/3) or open a new issue.
This has been fixed since v1.4.0. If you encounter a related issue, look at and comment on [issue #3](https://github.com/fjwillemsen/NativeOverleaf/issues/3).

### Unable to open on Mac
If you get the message that "Apple can't verify this app doesn't contain malware", use right-click -> open to open it.
Expand Down
2 changes: 1 addition & 1 deletion Scripts/appversion.js
Original file line number Diff line number Diff line change
@@ -1 +1 @@
const appversion = "1.7.3";
const appversion = "1.7.4";
2 changes: 1 addition & 1 deletion bundled_script.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion compile-all.sh
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ appversion="--app-version $appversionnumber"
epochtime=$(date +%s)
buildversion="--build-version $appversionnumber.$epochtime"
script="--inject bundled_script.js"
internalurls="--internal-urls .*?(login|profile|engine|auth|accounts.*)\..*?(?<TLD>\.\w+?)(?:$|\/)" # matches all *(login|profile|engine|auth|accounts*).*.<top-level-domain> URLs until the first forward-slash, may be a too greedy because it will also match slugs (e.g. domain.com/login.file.html)
internalurls="--internal-urls .*?(login|profile|engine|auth|idp|identity|secure|account.*)\..*?(?<TLD>\.\w+?)(?:$|\/)" # matches all *(login|profile|engine|auth|account.*|etc...).*.<top-level-domain> URLs until the first forward-slash, may be a too greedy because it will also match slugs (e.g. domain.com/login.file.html)
basecommand="nativefier https://overleaf.com $destination $name $appversion $buildversion $internalurls $script --user-agent-honest --overwrite"

# function to compile while filtering the nativefier output so only relevant output remains
Expand Down

0 comments on commit 4ddeb34

Please sign in to comment.