Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve collapse_add_neg simplifcation rule #355

Merged
merged 3 commits into from
Oct 26, 2023
Merged

Improve collapse_add_neg simplifcation rule #355

merged 3 commits into from
Oct 26, 2023

Conversation

rihi
Copy link
Collaborator

@rihi rihi commented Oct 18, 2023

Some minor improvements to the CollapseAddNeg simplification rule allowing 2 new simplifications:

  • -(e0) + e1 -> e1 - e0
  • -(e0) - e1 -> -(e0 + e1)

@rihi rihi self-assigned this Oct 18, 2023
@blattm blattm self-requested a review October 26, 2023 08:54
blattm
blattm approved these changes Oct 26, 2023
View reviewed changes
Copy link
Collaborator

@blattm blattm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, thank you!

@blattm blattm enabled auto-merge (squash) October 26, 2023 08:58
@blattm blattm merged commit 39f0fa3 into main Oct 26, 2023
1 check passed
@blattm blattm deleted the improve-collapse-add-neg branch October 26, 2023 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blattm blattm blattm approved these changes

Assignees

@rihi rihi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rihi @blattm