Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix escaping of string literals #428

Merged
merged 4 commits into from
Aug 1, 2024
Merged

Fix escaping of string literals #428

merged 4 commits into from
Aug 1, 2024

Conversation

rihi
Copy link
Collaborator

@rihi rihi commented Jul 31, 2024

This PR fixes some cases where string literals were not properly escaped.

@rihi rihi added the bug Something isn't working label Jul 31, 2024
@rihi rihi self-assigned this Jul 31, 2024
@rihi rihi requested a review from blattm August 1, 2024 08:26
blattm
blattm approved these changes Aug 1, 2024
View reviewed changes
Copy link
Collaborator

@blattm blattm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@blattm blattm merged commit ad2f8a3 into main Aug 1, 2024
1 check passed
@blattm blattm deleted the fix-str-literal-escaping branch August 1, 2024 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blattm blattm blattm approved these changes

Assignees

@rihi rihi

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rihi @blattm