Merge pull request #862 from khiet/main

Remove redundant deletion of feature gate in Flipper::Adapters::ActiveRecord#set.
flippercloud · Apr 19, 2024 · 13c415c · 13c415c
2 parents 8a99cf8 + cd8939c
commit 13c415c
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 2 deletions.
diff --git a/lib/flipper/adapter_builder.rb b/lib/flipper/adapter_builder.rb
@@ -3,7 +3,7 @@ module Flipper
   #
   #   adapter = Flipper::AdapterBuilder.new do
   #     use Flipper::Adapters::Strict
-  #     use Flipper::Adapters::Memoizer
+  #     use Flipper::Adapters::Memoizable
   #     store Flipper::Adapters::Memory
   #   end.to_adapter
   #

diff --git a/lib/flipper/adapters/active_record.rb b/lib/flipper/adapters/active_record.rb
@@ -221,7 +221,6 @@ def set(feature, gate, thing, options = {})
           @gate_class.transaction do
             clear(feature) if clear_feature
             delete(feature, gate)
-            @gate_class.where(feature_key: feature.key, key: gate.key).destroy_all
             begin
               @gate_class.create! do |g|
                 g.feature_key = feature.key