Cache Improvements #848
Merged
Cache Improvements #848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Want to be able to cache in multi-tenant.
It wouldn't even really work. The first to acquire lock would do the get_all but then the next would do a get_multi until the get_all was finished. Let's just do a features + get_multi all the time. Then the path is always the same. Also simplifies expiration and write through stuff.
Not perfect but less tweaking of each of them now than before and they are more similar.
This simplifies the cache stuff because now its just cache_fetch, read_multi, write and delete.
We'll change them in breaking fashion in 2.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This DRYs up the cache adapters. They now all have the same parameters for initialize and the same defaults (save AS which defaults to not expiring). They can also all be prefixed.