Bump native Android deps (#873)

* bump Gradle to 8.2.1, bump Kotlin to 1.9.0

* bump deps, set min Flutter to 3.10

* fix analyzer being angry

* remove unnecessasry gradle files

* fix ktlint warnings

* flutter format -> dart format

.github/workflows/prepare.yaml

@@ -13,7 +13,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        flutter-version: ['3.0.x', '3.3.x', '3.7.x', '3.10.x']
+        flutter-version: ['3.10.x']
 
     steps:
       - name: Clone repository
@@ -47,7 +47,7 @@ jobs:
 
       - name: flutter format (example app)
         working-directory: ./example
-        run: flutter format --set-exit-if-changed .
+        run: dart format --set-exit-if-changed .
 
       - name: flutter analyze (example app)
         working-directory: ./example

android/build.gradle

@@ -1,15 +1,15 @@
 buildscript {
-    ext.kotlin_version = "1.7.22"
+    ext.kotlin_version = "1.9.0"
     repositories {
         google()
         mavenCentral()
         gradlePluginPortal()
     }
 
     dependencies {
-        classpath "com.android.tools.build:gradle:7.2.2"
+        classpath "com.android.tools.build:gradle:7.4.2"
         classpath "org.jetbrains.kotlin:kotlin-gradle-plugin:$kotlin_version"
-        classpath "org.jlleitschuh.gradle:ktlint-gradle:11.0.0"
+        classpath "org.jlleitschuh.gradle:ktlint-gradle:11.5.0"
     }
 }
 
@@ -29,7 +29,7 @@ rootProject.allprojects {
 
 android {
     namespace "vn.hunghd.flutterdownloader"
-    compileSdk 32
+    compileSdk 33
 
     compileOptions {
         sourceCompatibility JavaVersion.VERSION_1_8
@@ -46,7 +46,7 @@ android {
 
     defaultConfig {
         minSdk 19
-        targetSdk 32
+        targetSdk 33
     }
 }
 

android/src/main/kotlin/vn/hunghd/flutterdownloader/DownloadWorker.kt

@@ -257,7 +257,7 @@ class DownloadWorker(context: Context, params: WorkerParameters) :
         filename: String?,
         headers: String,
         isResume: Boolean,
-        timeout: Int,
+        timeout: Int
     ) {
         var actualFilename = filename
         var url = fileURL

android/src/main/kotlin/vn/hunghd/flutterdownloader/FlutterDownloaderPlugin.kt

@@ -91,7 +91,7 @@ class FlutterDownloaderPlugin : MethodChannel.MethodCallHandler, FlutterPlugin {
         requiresStorageNotLow: Boolean,
         saveInPublicStorage: Boolean,
         timeout: Int,
-        allowCellular: Boolean,
+        allowCellular: Boolean
     ): WorkRequest {
         return OneTimeWorkRequest.Builder(DownloadWorker::class.java)
             .setConstraints(

android/src/main/kotlin/vn/hunghd/flutterdownloader/TaskDao.kt

@@ -21,7 +21,7 @@ class TaskDao(private val dbHelper: TaskDbHelper) {
         TaskEntry.COLUMN_NAME_SHOW_NOTIFICATION,
         TaskEntry.COLUMN_NAME_TIME_CREATED,
         TaskEntry.COLUMN_SAVE_IN_PUBLIC_STORAGE,
-        TaskEntry.COLUMN_ALLOW_CELLULAR,
+        TaskEntry.COLUMN_ALLOW_CELLULAR
     )
 
     fun insertOrUpdateNewTask(

example/android/build.gradle

@@ -1,12 +1,12 @@
 buildscript {
-    ext.kotlin_version = "1.7.22"
+    ext.kotlin_version = "1.9.0"
     repositories {
         google()
         mavenCentral()
     }
 
     dependencies {
-        classpath "com.android.tools.build:gradle:7.2.2"
+        classpath "com.android.tools.build:gradle:7.4.2"
         classpath "org.jetbrains.kotlin:kotlin-gradle-plugin:$kotlin_version"
     }
 }

example/android/gradle/wrapper/gradle-wrapper.properties

@@ -2,4 +2,4 @@ distributionBase=GRADLE_USER_HOME
 distributionPath=wrapper/dists
 zipStoreBase=GRADLE_USER_HOME
 zipStorePath=wrapper/dists
-distributionUrl=https\://services.gradle.org/distributions/gradle-7.6-all.zip
+distributionUrl=https\://services.gradle.org/distributions/gradle-8.2.1-all.zip

example/lib/download_list_item.dart

@@ -12,9 +12,9 @@ class DownloadListItem extends StatelessWidget {
   });
 
   final ItemHolder? data;
-  final Function(TaskInfo?)? onTap;
-  final Function(TaskInfo)? onActionTap;
-  final Function(TaskInfo)? onCancel;
+  final void Function(TaskInfo?)? onTap;
+  final void Function(TaskInfo)? onActionTap;
+  final void Function(TaskInfo)? onCancel;
 
   Widget? _buildTrailing(TaskInfo task) {
     if (task.status == DownloadTaskStatus.undefined) {

example/pubspec.yaml

@@ -4,8 +4,8 @@ version: 1.0.0+1
 publish_to: none
 
 environment:
-  sdk: '>=2.17.0 <4.0.0'
-  flutter: '>=3.0.0'
+  sdk: '>=3.0.0 <4.0.0'
+  flutter: '>=3.10.0'
 
 dependencies:
   android_path_provider: ^0.3.0
@@ -20,7 +20,7 @@ dependencies:
 dev_dependencies:
   flutter_test:
     sdk: flutter
-  leancode_lint: ^2.0.0+1
+  leancode_lint: ^4.0.0+2
 
 flutter:
   uses-material-design: true

lib/src/callback_dispatcher.dart

@@ -16,7 +16,8 @@ void callbackDispatcher() {
     ..setMethodCallHandler((call) async {
       final args = call.arguments as List<dynamic>;
       final handle = CallbackHandle.fromRawHandle(args[0] as int);
-      final callback = PluginUtilities.getCallbackFromHandle(handle);
+      final callback = PluginUtilities.getCallbackFromHandle(handle) as void
+          Function(String id, int status, int progress)?;
 
       if (callback == null) {
         // ignore: avoid_print

lib/src/downloader.dart

@@ -1,3 +1,5 @@
+// ignore_for_file: avoid_dynamic_calls
+
 import 'dart:async';
 import 'dart:convert';
 import 'dart:io';
@@ -149,8 +151,6 @@ class FlutterDownloader {
 
       return result.map(
         (dynamic item) {
-          // item as Map<String, dynamic>; // throws
-
           return DownloadTask(
             taskId: item['task_id'] as String,
             status: DownloadTaskStatus(item['status'] as int),
@@ -209,8 +209,6 @@ class FlutterDownloader {
 
       return result.map(
         (dynamic item) {
-          // item as Map<String, dynamic>; // throws
-
           return DownloadTask(
             taskId: item['task_id'] as String,
             status: DownloadTaskStatus(item['status'] as int),

pubspec.yaml

@@ -15,8 +15,8 @@ flutter:
         pluginClass: FlutterDownloaderPlugin
 
 environment:
-  sdk: '>=2.17.0 <4.0.0'
-  flutter: '>=3.0.0'
+  sdk: '>=3.0.0 <4.0.0'
+  flutter: '>=3.10.0'
 
 dependencies:
   flutter:
@@ -25,4 +25,4 @@ dependencies:
 dev_dependencies:
   flutter_test:
     sdk: flutter
-  leancode_lint: ^2.0.0+1
+  leancode_lint: ^4.0.0+2