Fix migration #949
Fix migration #949
Conversation
| if (oldVersion > 1) { | ||
| return | ||
| } | ||
| db.execSQL(SQL_DELETE_ENTRIES) | ||
| onCreate(db) |
There was a problem hiding this comment.
In the old version, this was executed when updating from 1 to 2, so I think it will work now.
https://github.com/fluttercommunity/flutter_downloader/blob/v1.6.1/android/src/main/java/vn/hunghd/flutterdownloader/TaskDbHelper.java#L59-L60
There was a problem hiding this comment.
@bowyer-app can you write some comments on your code explaining the change
|
Hello @bartekpacia @salmaahhmed I hope you're doing well. I would greatly appreciate it if you could take the time to review it. Thank you in advance! Best regards |
|
I know you're busy, but could you please review this for me? |
|
hey @bowyer-app, sorry for the delay. I'll try to get to it in the weekend. I'm indeed busy. |
|
@bartekpacia |
|
Hi @bartekpacia, I hope you're doing well. I just wanted to kindly follow up on this PR that we discussed a while ago. I understand you might be busy, but it would be great if you could let me know when you might have a chance to look into it. Thank you for your time! |
| if (oldVersion > 1) { | ||
| return | ||
| } | ||
| db.execSQL(SQL_DELETE_ENTRIES) | ||
| onCreate(db) |
There was a problem hiding this comment.
@bowyer-app can you write some comments on your code explaining the change
close #948